add shaded guava collections and use it #2086
Conversation
| return (ImmutableMapWithNullValues<K, V>) values; | ||
| } | ||
| return new ImmutableMapWithNullValues<>(values); | ||
| } |
There was a problem hiding this comment.
Didnt want to put a of helper here
ImmutableMapWithNullValues.of("k1", "v1")
ImmutableMapWithNullValues.of("k1", "v1", "k2", "v2")
| @@ -66,7 +69,7 @@ private DataFetchingEnvironmentImpl(Builder builder) { | |||
| this.locale = builder.locale; | |||
| this.operationDefinition = builder.operationDefinition; | |||
| this.document = builder.document; | |||
| this.variables = builder.variables == null ? Collections.emptyMap() : builder.variables; | |||
| this.variables = builder.variables == null ? ImmutableMapWithNullValues.empty() : builder.variables; | |||
There was a problem hiding this comment.
Maybe renamed ImmutableMapWithNullValues.empty() =to ImmutableMapWithNullValues.emptyMap() - this would be clearer in my book and also better on static import
this.variables = builder.variables == null ? emptyMap() : builder.variables;
|
Quite happy to see this PR! I believe that the approach is very good overall and In JDK11 there are also immutable maps and lists with some nice goodies (e.g. smart Besides that, I would like to test this PR in our project and report some early feedback. |
graphql-java plans to be a late adopter of JDK 11 - namely because so many users are not there yet. |
…ns-guava # Conflicts: # src/main/java/graphql/schema/DataFetchingFieldSelectionSetImpl.java # src/test/groovy/graphql/schema/DataFetchingFieldSelectionSetImplTest.groovy
| return instrumentation.beginField(parameters.withNewState(state)); | ||
| }) | ||
| .collect(toList())); | ||
| return new ChainedInstrumentationContext<>(map(instrumentations, instrumentation -> { |
There was a problem hiding this comment.
why the format change here?
| @@ -169,7 +196,7 @@ public GraphQLObjectType getObjectType(String typeName) { | |||
| } | |||
|
|
|||
| public Map<String, GraphQLNamedType> getTypeMap() { | |||
There was a problem hiding this comment.
doesn't nee to be a copy
andimarek
changed the title
This is an internal change only: we are using guava Immutable collections now in a lot places for more performance and more clarity.